From 9d10bf58a3cd5a61a501e29efd174b4c8fe2b474 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 20 Feb 2013 22:06:41 +0100 Subject: [PATCH] stream_wrap: remove superfluous buffer len check It's a buffer so it's never bigger than Buffer::kMaxLength bytes, which in turn is always < INT_MAX. --- src/stream_wrap.cc | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/stream_wrap.cc b/src/stream_wrap.cc index fc9218e2e69..79b058356db 100644 --- a/src/stream_wrap.cc +++ b/src/stream_wrap.cc @@ -293,14 +293,6 @@ Handle StreamWrap::WriteBuffer(const Arguments& args) { Local buffer_obj = args[0]->ToObject(); size_t offset = 0; size_t length = Buffer::Length(buffer_obj); - - if (length > INT_MAX) { - uv_err_t err; - err.code = UV_ENOBUFS; - SetErrno(err); - return scope.Close(v8::Null(node_isolate)); - } - char* storage = new char[sizeof(WriteWrap)]; WriteWrap* req_wrap = new (storage) WriteWrap(); @@ -317,7 +309,8 @@ Handle StreamWrap::WriteBuffer(const Arguments& args) { StreamWrap::AfterWrite); req_wrap->Dispatched(); - req_wrap->object_->Set(bytes_sym, Number::New((uint32_t) length)); + req_wrap->object_->Set(bytes_sym, + Integer::NewFromUnsigned(length, node_isolate)); wrap->UpdateWriteQueueSize();