1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor domain tests

Browse Source 
* Check that noop callback is or isn't invoked as appropriate using
  common.mustCall() and common.mustNotCall()
* Fix typo in array literal

PR-URL: https://github.com/nodejs/node/pull/13480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Rich Trott 2017-06-05 11:22:26 -07:00
parent c20c570282
commit b4da30f26c
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-domain-crypto.js
View File

@ -37,9 +37,9 @@ global.domain = require('domain');
// should not throw a 'TypeError: undefined is not a function' exception // should not throw a 'TypeError: undefined is not a function' exception
crypto.randomBytes(8); crypto.randomBytes(8);
crypto.randomBytes(8, common.noop); crypto.randomBytes(8, common.mustCall());
const buf = Buffer.alloc(8); const buf = Buffer.alloc(8);
crypto.randomFillSync(buf); crypto.randomFillSync(buf);
crypto.pseudoRandomBytes(8); crypto.pseudoRandomBytes(8);
crypto.pseudoRandomBytes(8, common.noop); crypto.pseudoRandomBytes(8, common.mustCall());
crypto.pbkdf2('password', 'salt', 8, 8, 'sha1', common.noop); crypto.pbkdf2('password', 'salt', 8, 8, 'sha1', common.mustCall());

2
test/parallel/test-domain-timers.js
View File

@ -51,4 +51,4 @@ immediated.run(function() {
}); });
}); });
const timeout = setTimeout(common.noop, 10 * 1000); const timeout = setTimeout(common.mustNotCall(), 10 * 1000);

4
test/parallel/test-domain.js
View File

@ -22,7 +22,7 @@
'use strict'; 'use strict';
// Simple tests of most basic domain functionality. // Simple tests of most basic domain functionality.
const common = require('../common'); require('../common');
const assert = require('assert'); const assert = require('assert');
const domain = require('domain'); const domain = require('domain');
const events = require('events'); const events = require('events');
@ -259,7 +259,7 @@ const fst = fs.createReadStream('stream for nonexistent file');
d.add(fst); d.add(fst);
expectCaught++; expectCaught++;
[42, null, , false, common.noop, 'string'].forEach(function(something) { [42, null, undefined, false, () => {}, 'string'].forEach(function(something) {
const d = new domain.Domain(); const d = new domain.Domain();
d.run(function() { d.run(function() {
process.nextTick(function() { process.nextTick(function() {