1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: check callback not invoked on lookup error

Browse Source 
Use `common.mustNotCall()` to confirm that callback is not invoked when
`dns.lookup()` throws.

PR-URL: https://github.com/nodejs/node/pull/13456
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This commit is contained in:
Rich Trott 2017-06-04 11:19:05 -07:00
parent 8d2bd5fa88
commit c20c570282
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-dns-lookup.js
View File

@ -24,7 +24,7 @@ assert.throws(() => {
hints: 100,
family: 0,
all: false
}, common.noop);
}, common.mustNotCall());
}, /^TypeError: Invalid argument: hints must use valid flags$/);
assert.throws(() => {
@ -32,7 +32,7 @@ assert.throws(() => {
hints: 0,
family: 20,
all: false
}, common.noop);
}, common.mustNotCall());
}, /^TypeError: Invalid argument: family must be 4 or 6$/);
assert.doesNotThrow(() => {