1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: fix backwards incompatibility

Browse Source 
4a86803f6 introduced a backwards incompatibility by accident
and was not caught due to an existing test that wasn't strict enough.

This commit fixes both the backwards incompatibility and the test.

PR-URL: https://github.com/nodejs/node/pull/12439
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Brian White 2017-04-16 03:42:22 -04:00 committed by James M Snell
parent 2519757b80
commit 7cd0d4f644
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/buffer.js
View File

@ -456,10 +456,7 @@ function byteLength(string, encoding) {
return len >>> 1; return len >>> 1;
break; break;
} }
if (mustMatch) return (mustMatch ? -1 : binding.byteLengthUtf8(string));
throw new TypeError('Unknown encoding: ' + encoding);
else
return binding.byteLengthUtf8(string);
} }
Buffer.byteLength = byteLength; Buffer.byteLength = byteLength;

3
test/parallel/test-buffer-alloc.js
View File

@ -885,7 +885,8 @@ assert.throws(() => Buffer.allocUnsafe(8).writeFloatLE(0.0, -1), RangeError);
} }
// Regression test for #5482: should throw but not assert in C++ land. // Regression test for #5482: should throw but not assert in C++ land.
assert.throws(() => Buffer.from('', 'buffer'), TypeError); assert.throws(() => Buffer.from('', 'buffer'),
/^TypeError: "encoding" must be a valid string encoding$/);
// Regression test for #6111. Constructing a buffer from another buffer // Regression test for #6111. Constructing a buffer from another buffer
// should a) work, and b) not corrupt the source buffer. // should a) work, and b) not corrupt the source buffer.