1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use dynamic port in 3 test-cluster-worker tests

Browse Source 
Remove common.PORT from test-cluster-worker-disconnect,
test-cluster-worker-exit and test-cluster-worker-kill to
eliminate the possibility that a dynamic port used in
another test will collide with common.PORT.

PR-URL: https://github.com/nodejs/node/pull/12443
Ref: https://github.com/nodejs/node/issues/12376
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Sebastian Plesciuc 2017-04-17 07:58:01 +03:00 committed by James M Snell
parent def78e8825
commit 2519757b80
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-cluster-worker-disconnect.js
View File

@ -28,7 +28,7 @@ if (cluster.isWorker) {
const http = require('http');
http.Server(() => {
}).listen(common.PORT, '127.0.0.1');
}).listen(0, '127.0.0.1');
const worker = cluster.worker;
assert.strictEqual(worker.exitedAfterDisconnect, worker.suicide);

2
test/parallel/test-cluster-worker-exit.js
View File

@ -40,7 +40,7 @@ if (cluster.isWorker) {
server.once('listening', common.mustCall(() => {
process.exit(EXIT_CODE);
}));
server.listen(common.PORT, '127.0.0.1');
server.listen(0, '127.0.0.1');
} else if (cluster.isMaster) {

2
test/parallel/test-cluster-worker-kill.js
View File

@ -36,7 +36,7 @@ if (cluster.isWorker) {
const server = http.Server(() => { });
server.once('listening', common.mustCall(() => { }));
server.listen(common.PORT, '127.0.0.1');
server.listen(0, '127.0.0.1');
} else if (cluster.isMaster) {