1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: reduce flakiness in test-heapdump-http2

Browse Source 
By the time the response event is emitted on the client's side, the
file may have already been fully piped and the stream pipe
may have been destroyed, so the test should not look for the
stream pipe in the snapshot.

PR-URL: https://github.com/nodejs/node/pull/58148
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Joyee Cheung 2025-05-05 23:32:09 +02:00 committed by GitHub
parent f275121b72
commit 5f48fddd3a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/pummel/test-heapdump-http2.js
View File

@ -48,10 +48,9 @@ server.listen(0, () => {
{ node_name: 'TCP', edge_name: 'native_to_javascript' },
]);
// `Node / StreamPipe` (C++) -> StreamPipe (JS)
validateByRetainingPathFromNodes(nodes, 'Node / StreamPipe', [
{ node_name: 'StreamPipe', edge_name: 'native_to_javascript' },
]);
// We don't necessarily have Node / StreamPipe here because by the time the
// response event is emitted, the file may have already been fully piped here
// and the stream pipe may have been destroyed.
// `Node / Http2Session` (C++) -> Http2Session (JS)
const sessions = validateByRetainingPathFromNodes(nodes, 'Node / Http2Session', []);