From 5f48fddd3a61502efc40bb218211ed71e17792e5 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Mon, 5 May 2025 23:32:09 +0200 Subject: [PATCH] test: reduce flakiness in test-heapdump-http2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit By the time the response event is emitted on the client's side, the file may have already been fully piped and the stream pipe may have been destroyed, so the test should not look for the stream pipe in the snapshot. PR-URL: https://github.com/nodejs/node/pull/58148 Reviewed-By: Juan José Arboleda Reviewed-By: Luigi Pinca --- test/pummel/test-heapdump-http2.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/test/pummel/test-heapdump-http2.js b/test/pummel/test-heapdump-http2.js index 9a60a238b49..74e9fdd5ff9 100644 --- a/test/pummel/test-heapdump-http2.js +++ b/test/pummel/test-heapdump-http2.js @@ -48,10 +48,9 @@ server.listen(0, () => { { node_name: 'TCP', edge_name: 'native_to_javascript' }, ]); - // `Node / StreamPipe` (C++) -> StreamPipe (JS) - validateByRetainingPathFromNodes(nodes, 'Node / StreamPipe', [ - { node_name: 'StreamPipe', edge_name: 'native_to_javascript' }, - ]); + // We don't necessarily have Node / StreamPipe here because by the time the + // response event is emitted, the file may have already been fully piped here + // and the stream pipe may have been destroyed. // `Node / Http2Session` (C++) -> Http2Session (JS) const sessions = validateByRetainingPathFromNodes(nodes, 'Node / Http2Session', []);