1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

win, build: fix building addons on Windows

Browse Source 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: https://github.com/nodejs/node/issues/25096

PR-URL: https://github.com/nodejs/node/pull/25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Bartosz Sosnowski 2018-12-18 14:11:54 +01:00 committed by Anna Henningsen
parent 9b60bcb3b9
commit 571273adad
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vcbuild.bat
View File

@ -446,8 +446,8 @@ if errorlevel 1 goto exit
:install-doctools :install-doctools
REM only install if building doc OR testing doctool REM only install if building doc OR testing doctool OR building addons
if not defined doc ( if not defined doc if not defined build_addons (
echo.%test_args% | findstr doctool 1>nul echo.%test_args% | findstr doctool 1>nul
if errorlevel 1 goto :skip-install-doctools if errorlevel 1 goto :skip-install-doctools
) )