From 571273adad22ba2f77221e10b85de501c48b1102 Mon Sep 17 00:00:00 2001 From: Bartosz Sosnowski Date: Tue, 18 Dec 2018 14:11:54 +0100 Subject: [PATCH] win, build: fix building addons on Windows Building addons would fail because addon-verify.js dependencies from tools\doc where not installed. This fixes this issue by installing those dependencies if addons are to be built. Fixes: https://github.com/nodejs/node/issues/25096 PR-URL: https://github.com/nodejs/node/pull/25108 Reviewed-By: Ruben Bridgewater --- vcbuild.bat | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vcbuild.bat b/vcbuild.bat index 215d0f44543..aa96555e88d 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -446,8 +446,8 @@ if errorlevel 1 goto exit :install-doctools -REM only install if building doc OR testing doctool -if not defined doc ( +REM only install if building doc OR testing doctool OR building addons +if not defined doc if not defined build_addons ( echo.%test_args% | findstr doctool 1>nul if errorlevel 1 goto :skip-install-doctools )