1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: do not copy v8-inspector* headers ar part of install

Browse Source 
These headers are exposed from V8 for embedder and should not be
used by native addons.

Fixes https://github.com/nodejs/node/issues/22415

PR-URL: https://github.com/nodejs/node/pull/22586
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
Alexey Kozyatinskiy 2018-08-29 09:31:25 -07:00 committed by Anna Henningsen
parent 21e8ce2297
commit 4b47d2907d
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/install.py
View File

@ -157,6 +157,14 @@ def files(action):
headers(action) headers(action)
def headers(action): def headers(action):
def ignore_inspector_headers(files, dest):
inspector_headers = [
'deps/v8/include/v8-inspector.h',
'deps/v8/include/v8-inspector-protocol.h'
]
files = filter(lambda name: name not in inspector_headers, files)
action(files, dest)
action([ action([
'common.gypi', 'common.gypi',
'config.gypi', 'config.gypi',
@ -172,7 +180,7 @@ def headers(action):
if sys.platform.startswith('aix'): if sys.platform.startswith('aix'):
action(['out/Release/node.exp'], 'include/node/') action(['out/Release/node.exp'], 'include/node/')
subdir_files('deps/v8/include', 'include/node/', action) subdir_files('deps/v8/include', 'include/node/', ignore_inspector_headers)
if 'false' == variables.get('node_shared_libuv'): if 'false' == variables.get('node_shared_libuv'):
subdir_files('deps/uv/include', 'include/node/', action) subdir_files('deps/uv/include', 'include/node/', action)