From 4b47d2907ddcd3240f98a6c2db82815a864a346c Mon Sep 17 00:00:00 2001 From: Alexey Kozyatinskiy Date: Wed, 29 Aug 2018 09:31:25 -0700 Subject: [PATCH] build: do not copy v8-inspector* headers ar part of install MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These headers are exposed from V8 for embedder and should not be used by native addons. Fixes https://github.com/nodejs/node/issues/22415 PR-URL: https://github.com/nodejs/node/pull/22586 Reviewed-By: Anna Henningsen Reviewed-By: Refael Ackermann Reviewed-By: Michaël Zasso --- tools/install.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/install.py b/tools/install.py index ce9ceeee1dd..9e192a1cd6e 100755 --- a/tools/install.py +++ b/tools/install.py @@ -157,6 +157,14 @@ def files(action): headers(action) def headers(action): + def ignore_inspector_headers(files, dest): + inspector_headers = [ + 'deps/v8/include/v8-inspector.h', + 'deps/v8/include/v8-inspector-protocol.h' + ] + files = filter(lambda name: name not in inspector_headers, files) + action(files, dest) + action([ 'common.gypi', 'config.gypi', @@ -172,7 +180,7 @@ def headers(action): if sys.platform.startswith('aix'): action(['out/Release/node.exp'], 'include/node/') - subdir_files('deps/v8/include', 'include/node/', action) + subdir_files('deps/v8/include', 'include/node/', ignore_inspector_headers) if 'false' == variables.get('node_shared_libuv'): subdir_files('deps/uv/include', 'include/node/', action)