1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

report: fix build warning in node_report.cc

Browse Source 
Fixes `maybe-uninitialized` build warning in `src/node_report.cc`.

PR-URL: https://github.com/nodejs/node/pull/26265
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Richard Lau 2019-02-22 13:22:06 -05:00
parent cd302d70dd
commit 4a10ce6883
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/node_report.cc
View File

@ -172,16 +172,14 @@ std::string TriggerNodeReport(Isolate* isolate,
std::cerr << " (errno: " << errno << ")" << std::endl; std::cerr << " (errno: " << errno << ")" << std::endl;
return ""; return "";
} }
outstream = &outfile;
std::cerr << std::endl std::cerr << std::endl
<< "Writing Node.js report to file: " << filename << std::endl; << "Writing Node.js report to file: " << filename << std::endl;
} }
// Pass our stream about by reference, not by copying it. WriteNodeReport(isolate, env, message, location, filename, *outstream,
std::ostream& out = outfile.is_open() ? outfile : *outstream; stackstr, &tm_struct);
WriteNodeReport(
isolate, env, message, location, filename, out, stackstr, &tm_struct);
// Do not close stdout/stderr, only close files we opened. // Do not close stdout/stderr, only close files we opened.
if (outfile.is_open()) { if (outfile.is_open()) {