From 4a10ce68836c9294006f81b8aa74d2b2890bd0c9 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 22 Feb 2019 13:22:06 -0500 Subject: [PATCH] report: fix build warning in node_report.cc Fixes `maybe-uninitialized` build warning in `src/node_report.cc`. PR-URL: https://github.com/nodejs/node/pull/26265 Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Michael Dawson --- src/node_report.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/node_report.cc b/src/node_report.cc index a379f0621f9..bd6e7100416 100644 --- a/src/node_report.cc +++ b/src/node_report.cc @@ -172,16 +172,14 @@ std::string TriggerNodeReport(Isolate* isolate, std::cerr << " (errno: " << errno << ")" << std::endl; return ""; } + outstream = &outfile; std::cerr << std::endl << "Writing Node.js report to file: " << filename << std::endl; } - // Pass our stream about by reference, not by copying it. - std::ostream& out = outfile.is_open() ? outfile : *outstream; - - WriteNodeReport( - isolate, env, message, location, filename, out, stackstr, &tm_struct); + WriteNodeReport(isolate, env, message, location, filename, *outstream, + stackstr, &tm_struct); // Do not close stdout/stderr, only close files we opened. if (outfile.is_open()) {