1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: support server options on createServer

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/19461
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Wes Todd 2018-03-19 16:14:46 -07:00 committed by Tobias Nießen
parent c1ed782ab4
commit 42d8ea0220
No known key found for this signature in database
GPG Key ID: 718207F8FD156B70
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/http.js
View File

@ -33,8 +33,8 @@ const {
ServerResponse ServerResponse
} = require('_http_server'); } = require('_http_server');
function createServer(requestListener) { function createServer(opts, requestListener) {
return new Server(requestListener); return new Server(opts, requestListener);
} }
function request(options, cb) { function request(options, cb) {

2
test/parallel/test-http-server-options-incoming-message.js
View File

@ -16,7 +16,7 @@ class MyIncomingMessage extends http.IncomingMessage {
} }
} }
const server = http.Server({ const server = http.createServer({
IncomingMessage: MyIncomingMessage IncomingMessage: MyIncomingMessage
}, common.mustCall(function(req, res) { }, common.mustCall(function(req, res) {
assert.strictEqual(req.getUserAgent(), 'node-test'); assert.strictEqual(req.getUserAgent(), 'node-test');