From 42d8ea02201f97450c7128f102baad67c6e54d9e Mon Sep 17 00:00:00 2001 From: Wes Todd Date: Mon, 19 Mar 2018 16:14:46 -0700 Subject: [PATCH] http: support server options on createServer PR-URL: https://github.com/nodejs/node/pull/19461 Reviewed-By: Anna Henningsen Reviewed-By: Evan Lucas Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- lib/http.js | 4 ++-- test/parallel/test-http-server-options-incoming-message.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/http.js b/lib/http.js index 8431ab0d51e..9ed6b3d1de8 100644 --- a/lib/http.js +++ b/lib/http.js @@ -33,8 +33,8 @@ const { ServerResponse } = require('_http_server'); -function createServer(requestListener) { - return new Server(requestListener); +function createServer(opts, requestListener) { + return new Server(opts, requestListener); } function request(options, cb) { diff --git a/test/parallel/test-http-server-options-incoming-message.js b/test/parallel/test-http-server-options-incoming-message.js index a4bfa1b7646..d0f4a769d76 100644 --- a/test/parallel/test-http-server-options-incoming-message.js +++ b/test/parallel/test-http-server-options-incoming-message.js @@ -16,7 +16,7 @@ class MyIncomingMessage extends http.IncomingMessage { } } -const server = http.Server({ +const server = http.createServer({ IncomingMessage: MyIncomingMessage }, common.mustCall(function(req, res) { assert.strictEqual(req.getUserAgent(), 'node-test');