1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: rename and document tls test

Browse Source 
Add a short description and one question to a TLS test.
Also, rename it since the previous name might unintentionally
evoke connotations to an internet meme that would generally
not be considered appropriate in our context.

PR-URL: https://github.com/nodejs/node/pull/20820
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This commit is contained in:
Anna Henningsen 2018-05-18 14:22:26 +02:00 committed by Anatoli Papirovski
parent 464852b1c6
commit 3c10d57ee4
No known key found for this signature in database
GPG Key ID: 614E2E1ABEB4B2C0
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/parallel/test-tls-two-cas-one-string.js → test/parallel/test-tls-multiple-cas-as-string.js
View File

@ -4,6 +4,9 @@ const common = require('../common');
if (!common.hasCrypto) if (!common.hasCrypto)
common.skip('missing crypto'); common.skip('missing crypto');
// Verify that multiple CA certificates can be provided, and that for
// convenience that can also be in newline-separated strings.
const tls = require('tls'); const tls = require('tls');
const fixtures = require('../common/fixtures'); const fixtures = require('../common/fixtures');
@ -30,6 +33,8 @@ function test(ca, next) {
} }
} }
// `ca1` is not actually necessary for the certificate validation -- maybe
// the fixtures should be written in a way that requires it?
const array = [ca1, ca2]; const array = [ca1, ca2];
const string = `${ca1}\n${ca2}`; const string = `${ca1}\n${ca2}`;
test(array, common.mustCall(() => test(string))); test(array, common.mustCall(() => test(string)));