From 3c10d57ee4381eef1d218fdfca212656e545d5e1 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 18 May 2018 14:22:26 +0200 Subject: [PATCH] test: rename and document tls test Add a short description and one question to a TLS test. Also, rename it since the previous name might unintentionally evoke connotations to an internet meme that would generally not be considered appropriate in our context. PR-URL: https://github.com/nodejs/node/pull/20820 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Colin Ihrig Reviewed-By: Trivikram Kamat Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Ujjwal Sharma --- ...-cas-one-string.js => test-tls-multiple-cas-as-string.js} | 5 +++++ 1 file changed, 5 insertions(+) rename test/parallel/{test-tls-two-cas-one-string.js => test-tls-multiple-cas-as-string.js} (77%) diff --git a/test/parallel/test-tls-two-cas-one-string.js b/test/parallel/test-tls-multiple-cas-as-string.js similarity index 77% rename from test/parallel/test-tls-two-cas-one-string.js rename to test/parallel/test-tls-multiple-cas-as-string.js index bbde78a24ed..2612de55fe9 100644 --- a/test/parallel/test-tls-two-cas-one-string.js +++ b/test/parallel/test-tls-multiple-cas-as-string.js @@ -4,6 +4,9 @@ const common = require('../common'); if (!common.hasCrypto) common.skip('missing crypto'); +// Verify that multiple CA certificates can be provided, and that for +// convenience that can also be in newline-separated strings. + const tls = require('tls'); const fixtures = require('../common/fixtures'); @@ -30,6 +33,8 @@ function test(ca, next) { } } +// `ca1` is not actually necessary for the certificate validation -- maybe +// the fixtures should be written in a way that requires it? const array = [ca1, ca2]; const string = `${ca1}\n${ca2}`; test(array, common.mustCall(() => test(string)));