1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http2: do not override the allowHalfOpen option

Browse Source 
The constructors of `tls.Server` and `Http2Server` call the super
constructors without options so the `allowHalfOpen` option is never used
regardless of its value.

PR-URL: https://github.com/nodejs/node/pull/27623
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Luigi Pinca 2019-05-09 15:21:47 +02:00 committed by Daniel Bevenius
parent 639b85950b
commit 3309c856bc
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/internal/http2/core.js
View File

@ -2641,7 +2641,6 @@ function connectionListener(socket) {
function initializeOptions(options) {
assertIsObject(options, 'options');
options = { ...options };
options.allowHalfOpen = true;
assertIsObject(options.settings, 'options.settings');
options.settings = { ...options.settings };