From 3309c856bcc88751ee3b4512f9a9b95fe903e361 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Thu, 9 May 2019 15:21:47 +0200 Subject: [PATCH] http2: do not override the allowHalfOpen option The constructors of `tls.Server` and `Http2Server` call the super constructors without options so the `allowHalfOpen` option is never used regardless of its value. PR-URL: https://github.com/nodejs/node/pull/27623 Reviewed-By: Rich Trott Reviewed-By: James M Snell --- lib/internal/http2/core.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js index 6ad1668c4f5..bd8639a6ea9 100644 --- a/lib/internal/http2/core.js +++ b/lib/internal/http2/core.js @@ -2641,7 +2641,6 @@ function connectionListener(socket) { function initializeOptions(options) { assertIsObject(options, 'options'); options = { ...options }; - options.allowHalfOpen = true; assertIsObject(options.settings, 'options.settings'); options.settings = { ...options.settings };