1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix abort/test-abort-uncaught-exception

Browse Source 
The --abort-on-uncaught-exception can terminate the process with either
a SIGABRT or a SIGILL signal but the test only expected SIGABRT.

PR-URL: https://github.com/nodejs/node/pull/6734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Ben Noordhuis 2016-06-19 10:14:24 +02:00
parent 5251fe52c3
commit 0672fca921
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/abort/test-abort-uncaught-exception.js
View File

@ -9,23 +9,26 @@ if (process.argv[2] === 'child') {
throw new Error('child error'); throw new Error('child error');
} else { } else {
run('', null); run('', null);
run('--abort-on-uncaught-exception', 'SIGABRT'); run('--abort-on-uncaught-exception', ['SIGABRT', 'SIGILL']);
} }
function run(flags, signal) { function run(flags, signals) {
const args = [__filename, 'child']; const args = [__filename, 'child'];
if (flags) if (flags)
args.unshift(flags); args.unshift(flags);
const child = spawn(node, args); const child = spawn(node, args);
child.on('exit', common.mustCall(function(code, sig) { child.on('exit', common.mustCall(function(code, sig) {
if (!common.isWindows) { if (common.isWindows) {
assert.strictEqual(sig, signal); if (signals)
} else {
if (signal)
assert.strictEqual(code, 3); assert.strictEqual(code, 3);
else else
assert.strictEqual(code, 1); assert.strictEqual(code, 1);
} else {
if (signals)
assert.strictEqual(signals.includes(sig), true);
else
assert.strictEqual(sig, null);
} }
})); }));
} }