From 0672fca921e3ace9f10309c58ead71fa31750e39 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Sun, 19 Jun 2016 10:14:24 +0200 Subject: [PATCH] test: fix abort/test-abort-uncaught-exception The --abort-on-uncaught-exception can terminate the process with either a SIGABRT or a SIGILL signal but the test only expected SIGABRT. PR-URL: https://github.com/nodejs/node/pull/6734 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig --- test/abort/test-abort-uncaught-exception.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/test/abort/test-abort-uncaught-exception.js b/test/abort/test-abort-uncaught-exception.js index 0d9fa6884df..f9847193769 100644 --- a/test/abort/test-abort-uncaught-exception.js +++ b/test/abort/test-abort-uncaught-exception.js @@ -9,23 +9,26 @@ if (process.argv[2] === 'child') { throw new Error('child error'); } else { run('', null); - run('--abort-on-uncaught-exception', 'SIGABRT'); + run('--abort-on-uncaught-exception', ['SIGABRT', 'SIGILL']); } -function run(flags, signal) { +function run(flags, signals) { const args = [__filename, 'child']; if (flags) args.unshift(flags); const child = spawn(node, args); child.on('exit', common.mustCall(function(code, sig) { - if (!common.isWindows) { - assert.strictEqual(sig, signal); - } else { - if (signal) + if (common.isWindows) { + if (signals) assert.strictEqual(code, 3); else assert.strictEqual(code, 1); + } else { + if (signals) + assert.strictEqual(signals.includes(sig), true); + else + assert.strictEqual(sig, null); } })); }