1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: master/cli: properly trim the '@@' process name in error messages

Browse Source 
When '@@' alone is sent on the master CLI (no trailing LF), we get an
error that displays anything past these two characters in the buffer
since there's no room for a \0. Let's make sure to limit the length of
the process name in this case. No backport is needed since this was added
with 00c967fac4 ("MINOR: master/cli: support bidirectional communications
with workers").
This commit is contained in:
Willy Tarreau 2025-04-24 17:47:23 +02:00
parent 29632bcabf
commit 0e94339eaf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cli.c
View File

@ -2927,7 +2927,7 @@ int pcli_find_bidir_prefix(struct stream *s, struct channel *req, char **str, co
target_pid = pcli_prefix_to_pid(pid_str + 1);
if (target_pid == -1) {
memprintf(errmsg, "Can't find the target PID matching the prefix '%s'\n", pid_str);
memprintf(errmsg, "Can't find the target PID matching the prefix '%.*s'\n", (int)(p - pid_str), pid_str);
ret = -1;
goto leave;
}