From 0e94339eaf1c8423132debb6b1b485d8bb1bb7da Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 24 Apr 2025 17:47:23 +0200 Subject: [PATCH] BUG/MINOR: master/cli: properly trim the '@@' process name in error messages When '@@' alone is sent on the master CLI (no trailing LF), we get an error that displays anything past these two characters in the buffer since there's no room for a \0. Let's make sure to limit the length of the process name in this case. No backport is needed since this was added with 00c967fac4 ("MINOR: master/cli: support bidirectional communications with workers"). --- src/cli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cli.c b/src/cli.c index 2b72df796..66908bd4a 100644 --- a/src/cli.c +++ b/src/cli.c @@ -2927,7 +2927,7 @@ int pcli_find_bidir_prefix(struct stream *s, struct channel *req, char **str, co target_pid = pcli_prefix_to_pid(pid_str + 1); if (target_pid == -1) { - memprintf(errmsg, "Can't find the target PID matching the prefix '%s'\n", pid_str); + memprintf(errmsg, "Can't find the target PID matching the prefix '%.*s'\n", (int)(p - pid_str), pid_str); ret = -1; goto leave; }