1berry/docker-cli
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cli/command/volume: TestVolumeCreateCluster: minor fixes and refactor

Browse Source 
- assert unhandled error
- use sub-tests
- use slightly more unique volume-names
- discard stdout/stderr output

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2025-02-01 14:17:25 +01:00
parent a8265e72bf
commit 5b8c08d19e
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
cli/command/volume/create_test.go
View File

@ -161,19 +161,27 @@ func TestVolumeCreateCluster(t *testing.T) {
}, },
}) })
cmd := newCreateCommand(cli) t.Run("csi-volume", func(t *testing.T) {
cmd.Flags().Set("type", "block") cmd := newCreateCommand(cli)
cmd.Flags().Set("group", "gronp") cmd.SetOut(io.Discard)
cmd.Flags().Set("driver", "csi") cmd.SetErr(io.Discard)
cmd.SetArgs([]string{"name"}) assert.Check(t, cmd.Flags().Set("type", "block"))
assert.Check(t, cmd.Flags().Set("group", "gronp"))
assert.Check(t, cmd.Flags().Set("driver", "csi"))
cmd.SetArgs([]string{"my-csi-volume"})
assert.NilError(t, cmd.Execute()) assert.NilError(t, cmd.Execute())
})
cmd = newCreateCommand(cli) t.Run("non-csi-volume", func(t *testing.T) {
cmd.Flags().Set("driver", "notcsi") cmd := newCreateCommand(cli)
cmd.SetArgs([]string{"name"}) cmd.SetOut(io.Discard)
cmd.SetErr(io.Discard)
assert.Check(t, cmd.Flags().Set("driver", "notcsi"))
cmd.SetArgs([]string{"my-non-csi-volume"})
assert.NilError(t, cmd.Execute()) assert.NilError(t, cmd.Execute())
})
} }
func TestVolumeCreateClusterOpts(t *testing.T) { func TestVolumeCreateClusterOpts(t *testing.T) {