From 5b8c08d19e3bda645058d66b0364569002ad577b Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sat, 1 Feb 2025 14:17:25 +0100 Subject: [PATCH] cli/command/volume: TestVolumeCreateCluster: minor fixes and refactor - assert unhandled error - use sub-tests - use slightly more unique volume-names - discard stdout/stderr output Signed-off-by: Sebastiaan van Stijn --- cli/command/volume/create_test.go | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/cli/command/volume/create_test.go b/cli/command/volume/create_test.go index 7c256c3051..e1c5c18eaf 100644 --- a/cli/command/volume/create_test.go +++ b/cli/command/volume/create_test.go @@ -161,19 +161,27 @@ func TestVolumeCreateCluster(t *testing.T) { }, }) - cmd := newCreateCommand(cli) - cmd.Flags().Set("type", "block") - cmd.Flags().Set("group", "gronp") - cmd.Flags().Set("driver", "csi") - cmd.SetArgs([]string{"name"}) + t.Run("csi-volume", func(t *testing.T) { + cmd := newCreateCommand(cli) + cmd.SetOut(io.Discard) + cmd.SetErr(io.Discard) + assert.Check(t, cmd.Flags().Set("type", "block")) + assert.Check(t, cmd.Flags().Set("group", "gronp")) + assert.Check(t, cmd.Flags().Set("driver", "csi")) + cmd.SetArgs([]string{"my-csi-volume"}) - assert.NilError(t, cmd.Execute()) + assert.NilError(t, cmd.Execute()) + }) - cmd = newCreateCommand(cli) - cmd.Flags().Set("driver", "notcsi") - cmd.SetArgs([]string{"name"}) + t.Run("non-csi-volume", func(t *testing.T) { + cmd := newCreateCommand(cli) + cmd.SetOut(io.Discard) + cmd.SetErr(io.Discard) + assert.Check(t, cmd.Flags().Set("driver", "notcsi")) + cmd.SetArgs([]string{"my-non-csi-volume"}) - assert.NilError(t, cmd.Execute()) + assert.NilError(t, cmd.Execute()) + }) } func TestVolumeCreateClusterOpts(t *testing.T) {