If the user has the encoding of her system messed up, she may end up sending us incorrectly encoding input, causing "invalid byte sequence in UTF-8" errors at random places. These errors can be forced on a system without encoding issues with something like: ``` $ gem install$(echo -e "\xFF") foo /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/config_file.rb:534:in `block in set_config_file_name': invalid byte sequence in UTF-8 (ArgumentError) from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/config_file.rb:530:in `each' from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/config_file.rb:530:in `set_config_file_name' from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/config_file.rb:177:in `initialize' from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/gem_runner.rb:71:in `new' from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/gem_runner.rb:71:in `do_configuration' from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems/gem_runner.rb:33:in `run' from /Users/deivid/.asdf/installs/ruby/3.2.1/bin/gem:10:in `<main>' ``` This commit makes RubyGems print a better error in this case: ``` $ ruby -Ilib bin/gem install$(echo -e "\xFF") foo /Users/deivid/Code/rubygems/rubygems/lib/rubygems/gem_runner.rb:75:in `validate_encoding': invalid argument: 'install�' has invalid encoding (Gem::OptionParser::InvalidArgument) from /Users/deivid/Code/rubygems/rubygems/lib/rubygems/gem_runner.rb:31:in `run' from bin/gem:10:in `<main>' ```
90 lines
2.1 KiB
Ruby
90 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
#--
|
|
# Copyright 2006 by Chad Fowler, Rich Kilmer, Jim Weirich and others.
|
|
# All rights reserved.
|
|
# See LICENSE.txt for permissions.
|
|
#++
|
|
|
|
require_relative "../rubygems"
|
|
require_relative "command_manager"
|
|
require_relative "deprecate"
|
|
|
|
##
|
|
# Run an instance of the gem program.
|
|
#
|
|
# Gem::GemRunner is only intended for internal use by RubyGems itself. It
|
|
# does not form any public API and may change at any time for any reason.
|
|
#
|
|
# If you would like to duplicate functionality of `gem` commands, use the
|
|
# classes they call directly.
|
|
|
|
class Gem::GemRunner
|
|
def initialize
|
|
@command_manager_class = Gem::CommandManager
|
|
@config_file_class = Gem::ConfigFile
|
|
end
|
|
|
|
##
|
|
# Run the gem command with the following arguments.
|
|
|
|
def run(args)
|
|
validate_encoding args
|
|
build_args = extract_build_args args
|
|
|
|
do_configuration args
|
|
|
|
begin
|
|
Gem.load_env_plugins
|
|
rescue StandardError
|
|
nil
|
|
end
|
|
Gem.load_plugins
|
|
|
|
cmd = @command_manager_class.instance
|
|
|
|
cmd.command_names.each do |command_name|
|
|
config_args = Gem.configuration[command_name]
|
|
config_args = case config_args
|
|
when String
|
|
config_args.split " "
|
|
else
|
|
Array(config_args)
|
|
end
|
|
Gem::Command.add_specific_extra_args command_name, config_args
|
|
end
|
|
|
|
cmd.run Gem.configuration.args, build_args
|
|
end
|
|
|
|
##
|
|
# Separates the build arguments (those following <code>--</code>) from the
|
|
# other arguments in the list.
|
|
|
|
def extract_build_args(args) # :nodoc:
|
|
return [] unless offset = args.index("--")
|
|
|
|
build_args = args.slice!(offset...args.length)
|
|
|
|
build_args.shift
|
|
|
|
build_args
|
|
end
|
|
|
|
private
|
|
|
|
def validate_encoding(args)
|
|
invalid_arg = args.find {|arg| !arg.valid_encoding? }
|
|
|
|
if invalid_arg
|
|
raise Gem::OptionParser::InvalidArgument.new("'#{invalid_arg.scrub}' has invalid encoding")
|
|
end
|
|
end
|
|
|
|
def do_configuration(args)
|
|
Gem.configuration = @config_file_class.new(args)
|
|
Gem.use_paths Gem.configuration[:gemhome], Gem.configuration[:gempath]
|
|
Gem::Command.extra_args = Gem.configuration[:gem]
|
|
end
|
|
end
|