1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] Avoid some unnecessary quotes in remember flag deprecation message

Browse Source 
https://github.com/rubygems/rubygems/commit/3fd627e486
This commit is contained in:
David Rodríguez 2023-11-23 23:01:35 +01:00 committed by Hiroshi SHIBATA
parent bd4bd61650
commit fe57be5a2e
2 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/bundler/cli.rb
View File

@ -884,12 +884,13 @@ module Bundler
value = options[name] value = options[name]
value = value.join(" ").to_s if option.type == :array value = value.join(" ").to_s if option.type == :array
value = "'#{value}'" unless option.type == :boolean
Bundler::SharedHelpers.major_deprecation 2, Bundler::SharedHelpers.major_deprecation 2,
"The `#{flag_name}` flag is deprecated because it relies on being " \ "The `#{flag_name}` flag is deprecated because it relies on being " \
"remembered across bundler invocations, which bundler will no longer " \ "remembered across bundler invocations, which bundler will no longer " \
"do in future versions. Instead please use `bundle config set #{name.tr("-", "_")} " \ "do in future versions. Instead please use `bundle config set #{name.tr("-", "_")} " \
"'#{value}'`, and stop using this flag" "#{value}`, and stop using this flag"
end end
end end
end end

22
spec/bundler/other/major_deprecation_spec.rb
View File

@ -370,16 +370,16 @@ RSpec.describe "major deprecations" do
end end
{ {
"clean" => ["clean", true], "clean" => ["clean", "true"],
"deployment" => ["deployment", true], "deployment" => ["deployment", "true"],
"frozen" => ["frozen", true], "frozen" => ["frozen", "true"],
"no-deployment" => ["deployment", false], "no-deployment" => ["deployment", "false"],
"no-prune" => ["no_prune", true], "no-prune" => ["no_prune", "true"],
"path" => ["path", "vendor/bundle"], "path" => ["path", "'vendor/bundle'"],
"shebang" => ["shebang", "ruby27"], "shebang" => ["shebang", "'ruby27'"],
"system" => ["system", true], "system" => ["system", "true"],
"without" => ["without", "development"], "without" => ["without", "'development'"],
"with" => ["with", "development"], "with" => ["with", "'development'"],
}.each do |name, expectations| }.each do |name, expectations|
option_name, value = *expectations option_name, value = *expectations
flag_name = "--#{name}" flag_name = "--#{name}"
@ -395,7 +395,7 @@ RSpec.describe "major deprecations" do
"The `#{flag_name}` flag is deprecated because it relies on " \ "The `#{flag_name}` flag is deprecated because it relies on " \
"being remembered across bundler invocations, which bundler " \ "being remembered across bundler invocations, which bundler " \
"will no longer do in future versions. Instead please use " \ "will no longer do in future versions. Instead please use " \
"`bundle config set #{option_name} '#{value}'`, and stop using this flag" "`bundle config set #{option_name} #{value}`, and stop using this flag"
) )
end end