From fc26004660a287b977e5481a09f6329ffa688357 Mon Sep 17 00:00:00 2001 From: Yusuke Endoh Date: Fri, 28 Mar 2025 13:34:32 +0900 Subject: [PATCH] Remove test_retry_workers The test fails randomly for unknown reason. https://github.com/ruby/ruby/actions/runs/14121674932/job/39562945096?pr=12993 ``` 1) Error: TestParallel::TestParallel#test_retry_workers: Test::Unit::ProxyError: execution expired (start: 2025-03-28 04:04:10 +0000, end: 2025-03-28 04:05:50 +0000) /home/runner/work/ruby/ruby/src/tool/test/testunit/test_parallel.rb:16:in 'TestParallel.timeout' /home/runner/work/ruby/ruby/src/tool/test/testunit/test_parallel.rb:225:in 'TestParallel::TestParallel#test_retry_workers' ``` Maybe the workers do not respond "quit" request. We no longer use the retry mechanism, so just remove the test. --- tool/test/testunit/test_parallel.rb | 7 ------- tool/test/testunit/tests_for_parallel/test4test_slow_0.rb | 5 ----- tool/test/testunit/tests_for_parallel/test4test_slow_1.rb | 5 ----- 3 files changed, 17 deletions(-) delete mode 100644 tool/test/testunit/tests_for_parallel/test4test_slow_0.rb delete mode 100644 tool/test/testunit/tests_for_parallel/test4test_slow_1.rb diff --git a/tool/test/testunit/test_parallel.rb b/tool/test/testunit/test_parallel.rb index d4c56b8737..a0cbca69eb 100644 --- a/tool/test/testunit/test_parallel.rb +++ b/tool/test/testunit/test_parallel.rb @@ -219,12 +219,5 @@ module TestParallel assert_match(/^Retrying hung up testcases\.+$/, buf) assert_match(/^2 tests,.* 0 failures,/, buf) end - - def test_retry_workers - spawn_runner "--worker-timeout=1", "--retry", "test4test_slow_0.rb", "test4test_slow_1.rb", jobs: "2" - buf = ::TestParallel.timeout(TIMEOUT) {@test_out.read.b} - assert_match(/^Retrying hung up testcases\.+$/, buf) - assert_match(/^2 tests,.* 0 failures,/, buf) - end end end diff --git a/tool/test/testunit/tests_for_parallel/test4test_slow_0.rb b/tool/test/testunit/tests_for_parallel/test4test_slow_0.rb deleted file mode 100644 index a749b0e1d3..0000000000 --- a/tool/test/testunit/tests_for_parallel/test4test_slow_0.rb +++ /dev/null @@ -1,5 +0,0 @@ -require_relative 'slow_helper' - -class TestSlowV0 < Test::Unit::TestCase - include TestSlowTimeout -end diff --git a/tool/test/testunit/tests_for_parallel/test4test_slow_1.rb b/tool/test/testunit/tests_for_parallel/test4test_slow_1.rb deleted file mode 100644 index 924a3b11fa..0000000000 --- a/tool/test/testunit/tests_for_parallel/test4test_slow_1.rb +++ /dev/null @@ -1,5 +0,0 @@ -require_relative 'slow_helper' - -class TestSlowV1 < Test::Unit::TestCase - include TestSlowTimeout -end