1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary checks in Range#each [Bug #18237]

Browse Source 
In commit:7817a438eb1803e7b3358f43bd1f38479badfbdc, the implementation
of `Time#succ`, which had been deprecated for 10 years, was finally
removed.

During that time, there was an explicit `instance_of?` check in
source:range.c#L350 with a comment that the check should be removed
once `Time#succ` is removed.

Since `Time#succ` is now gone, this check should be removed.

Note: this should be coordinated with adding a version guard to the
corresponding check in ruby/spec as well.
This commit is contained in:
Jörg W Mittag 2021-10-03 15:16:08 +02:00 committed by GitHub
parent 19f9d9cf73
commit fb03598666
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
Notes: git 2021-10-03 22:16:27 +09:00 
Merged: https://github.com/ruby/ruby/pull/4928

Merged-By: nobu <nobu@ruby-lang.org>
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
range.c
View File

@ -347,7 +347,6 @@ step_i(VALUE i, VALUE arg)
static int static int
discrete_object_p(VALUE obj) discrete_object_p(VALUE obj)
{ {
if (rb_obj_is_kind_of(obj, rb_cTime)) return FALSE; /* until Time#succ removed */
return rb_respond_to(obj, id_succ); return rb_respond_to(obj, id_succ);
} }