1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

* test/ruby/test_thread.rb: fix potential race condition.

Browse Source 
The thread could have a "sleep" status because it tries
  to acquire the mutex, but does not have it yet.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52041 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
eregon 2015-10-05 11:44:30 +00:00
parent 37ab3ed99d
commit fab171e541
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
Mon Oct 5 20:39:32 2015 Benoit Daloze <eregontp@gmail.com>
* test/ruby/test_thread.rb: fix potential race condition.
The thread could have a "sleep" status because it tries
to acquire the mutex, but does not have it yet.
Mon Oct 5 15:39:30 2015 Zachary Scott <zzak@ruby-lang.org> Mon Oct 5 15:39:30 2015 Zachary Scott <zzak@ruby-lang.org>
* numeric.c: [DOC] Overview for Numeric class by Joe Corcoran * numeric.c: [DOC] Overview for Numeric class by Joe Corcoran

5
test/ruby/test_thread.rb
View File

@ -914,9 +914,8 @@ q.pop
sleep sleep
} }
Thread.pass until th.status == "sleep" # acquired by another thread.
# acquired another thread. Thread.pass until mutex.locked?
assert_equal(mutex.locked?, true)
assert_equal(mutex.owned?, false) assert_equal(mutex.owned?, false)
ensure ensure
th.kill if th th.kill if th