[ruby/rdoc] Fix iPad Pro navigation not shown
(https://github.com/ruby/rdoc/pull/1236) Found this issue when I was debugging the navigation toggle. I noticed it first in the chrome dev tools, but it was also reproducible on an iPad Pro. Symptom: - On iPad Pro, the navigation section is hidden but there's enough space to show it. Making the user have to click the hamburger button to show it but it's not necessary to hide the navigation section. - On desktop, the navigation section is shown. - On mobile, the navigation section is hidden until the hamburger button is clicked. Fix: - The javascript code was matching 1024px instead of 1023px. The media sections of the css was altering the layout on 1024px. So ipad got the full desktop layout but the navigation section was hidden. https://github.com/ruby/rdoc/commit/1794e59755
This commit is contained in:
parent
2c57b87cc3
commit
f9dc41b6a9
@ -99,7 +99,7 @@ function hookSidebar() {
|
||||
navigationToggle.ariaExpanded = navigationToggle.ariaExpanded !== 'true';
|
||||
});
|
||||
|
||||
var isSmallViewport = window.matchMedia("(max-width: 1024px)").matches;
|
||||
var isSmallViewport = window.matchMedia("(max-width: 1023px)").matches;
|
||||
if (isSmallViewport) {
|
||||
navigation.hidden = true;
|
||||
navigationToggle.ariaExpanded = false;
|
||||
|
Loading…
x
Reference in New Issue
Block a user