From f91b1ab33d397fdcdf452d563d7f59469a078d88 Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Wed, 15 May 2019 21:08:49 -0700 Subject: [PATCH] Skip assertion in readline test if Readline version is 4.3 Previously, the entire method was not run for Readline 4.3, probably because it was known to fail. Commit c754e979d3eeca51f1b13778f19f347df3da656e removed the check for Readline 4.3. Other than this one assertion, which also doesn't work when using Reline, the method runs correctly when using Readline 4.3. Fixes [Bug #15853]. --- test/readline/test_readline.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/readline/test_readline.rb b/test/readline/test_readline.rb index e8e5a5aec2..e040ac53c3 100644 --- a/test/readline/test_readline.rb +++ b/test/readline/test_readline.rb @@ -405,7 +405,9 @@ module BasetestReadline line = Readline.readline("> ") assert_equal("hello world", line) end - if !defined?(Reline) or Readline != Reline # Reline's rendering logic is tricky + # Readline 4.3 doesn't include inserted text or input + # Reline's rendering logic is tricky + if Readline::VERSION != '4.3' and (!defined?(Reline) or Readline != Reline) assert_equal("> hello world\n", stdout.read) end stdout.close