From f8ef77af3bbd2690c81cffccdf40afe953c7e6a7 Mon Sep 17 00:00:00 2001 From: eileencodes Date: Wed, 17 Jan 2024 10:22:01 -0500 Subject: [PATCH] [Prism] Implement defined? for PM_INDEX_AND_WRITE_NODE Ruby code: ```ruby defined?([0][0] &&= 1) ``` Instructions: ``` "********* Ruby *************" == disasm: #@:1 (1,0)-(59,58)> 0000 putobject "assignment" ( 59)[Li] 0002 leave "********* PRISM *************" == disasm: #@:58 (58,0)-(58,58)> 0000 putobject "assignment" ( 58)[Li] 0002 leave ``` Related: ruby/prism#2188 --- prism_compile.c | 2 ++ test/ruby/test_compile_prism.rb | 1 + 2 files changed, 3 insertions(+) diff --git a/prism_compile.c b/prism_compile.c index be9be37411..4bcbeb1208 100644 --- a/prism_compile.c +++ b/prism_compile.c @@ -2710,6 +2710,8 @@ pm_compile_defined_expr0(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *co case PM_CLASS_VARIABLE_AND_WRITE_NODE: case PM_CLASS_VARIABLE_OR_WRITE_NODE: + case PM_INDEX_AND_WRITE_NODE: + case PM_INSTANCE_VARIABLE_WRITE_NODE: case PM_INSTANCE_VARIABLE_OPERATOR_WRITE_NODE: case PM_INSTANCE_VARIABLE_AND_WRITE_NODE: diff --git a/test/ruby/test_compile_prism.rb b/test/ruby/test_compile_prism.rb index 5e6b43d25a..d64cef57d8 100644 --- a/test/ruby/test_compile_prism.rb +++ b/test/ruby/test_compile_prism.rb @@ -245,6 +245,7 @@ module Prism assert_prism_eval("defined?(Prism::CPOWN += 1)") assert_prism_eval("defined?(Prism::CPOrWN ||= 1)") assert_prism_eval("defined?(Prism::CPWN = 1)") + assert_prism_eval("defined?([0][0] &&= 1)") end def test_GlobalVariableReadNode