1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/irb] Group show_doc tests and update the expectation

Browse Source 
(https://github.com/ruby/irb/pull/479)

https://github.com/ruby/irb/commit/bede04c14a
This commit is contained in:
Stan Lo 2022-12-12 21:04:58 +00:00 committed by git
parent 258ac07907
commit f88f2bd92f
1 changed files with 34 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
test/irb/test_cmd.rb
View File

@ -376,38 +376,6 @@ module TestIRB
assert_match(/Please specify the file name./, out) assert_match(/Please specify the file name./, out)
end end
def test_help_and_show_doc
["help", "show_doc"].each do |cmd|
out, _ = execute_lines(
"#{cmd} String#gsub\n",
"\n",
)
# the former is what we'd get without document content installed, like on CI
# the latter is what we may get locally
possible_rdoc_output = [/Nothing known about String#gsub/, /str.gsub\(pattern\)/]
assert(possible_rdoc_output.any? { |output| output.match?(out) }, "Expect the `#{cmd}` command to match one of the possible outputs")
end
ensure
# this is the only way to reset the redefined method without coupling the test with its implementation
EnvUtil.suppress_warning { load "irb/cmd/help.rb" }
end
def test_help_without_rdoc
out, _ = without_rdoc do
execute_lines(
"help 'String#gsub'\n",
"\n",
)
end
# if it fails to require rdoc, it only returns the command object
assert_match(/=> IRB::ExtendCommand::Help\n/, out)
ensure
# this is the only way to reset the redefined method without coupling the test with its implementation
EnvUtil.suppress_warning { load "irb/cmd/help.rb" }
end
def test_irb_load def test_irb_load
File.write("#{@tmpdir}/a.rb", "a = 'hi'\n") File.write("#{@tmpdir}/a.rb", "a = 'hi'\n")
out, err = execute_lines( out, err = execute_lines(
@ -612,6 +580,40 @@ module TestIRB
assert_match(/Start the debugger of debug\.gem/, out) assert_match(/Start the debugger of debug\.gem/, out)
end end
class ShowDocTest < CommandTestCase
def test_help_and_show_doc
["help", "show_doc"].each do |cmd|
out, _ = execute_lines(
"#{cmd} String#gsub\n",
"\n",
)
# the former is what we'd get without document content installed, like on CI
# the latter is what we may get locally
possible_rdoc_output = [/Nothing known about String#gsub/, /gsub\(pattern\)/]
assert(possible_rdoc_output.any? { |output| output.match?(out) }, "Expect the `#{cmd}` command to match one of the possible outputs. Got:\n#{out}")
end
ensure
# this is the only way to reset the redefined method without coupling the test with its implementation
EnvUtil.suppress_warning { load "irb/cmd/help.rb" }
end
def test_show_doc_without_rdoc
out, _ = without_rdoc do
execute_lines(
"show_doc String#gsub\n",
"\n",
)
end
# if it fails to require rdoc, it only returns the command object
assert_match(/=> IRB::ExtendCommand::Help\n/, out)
ensure
# this is the only way to reset the redefined method without coupling the test with its implementation
EnvUtil.suppress_warning { load "irb/cmd/help.rb" }
end
end
class EditTest < CommandTestCase class EditTest < CommandTestCase
def setup def setup
@original_editor = ENV["EDITOR"] @original_editor = ENV["EDITOR"]