1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rb_szqueue_push: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-19 10:56:25 +09:00
parent 8fc8912109
commit f402dc3557
Notes: git 2020-06-29 11:06:42 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
thread_sync.c
View File

@ -1156,7 +1156,7 @@ rb_szqueue_push(int argc, VALUE *argv, VALUE self)
rb_raise(rb_eThreadError, "queue full"); rb_raise(rb_eThreadError, "queue full");
} }
else if (queue_closed_p(self)) { else if (queue_closed_p(self)) {
goto closed; break;
} }
else { else {
struct queue_waiter qw; struct queue_waiter qw;
@ -1172,7 +1172,6 @@ rb_szqueue_push(int argc, VALUE *argv, VALUE self)
} }
if (queue_closed_p(self)) { if (queue_closed_p(self)) {
closed:
raise_closed_queue_error(self); raise_closed_queue_error(self);
} }