1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] Add missing open3 requires

Browse Source 
https://github.com/rubygems/rubygems/commit/06ad654120
This commit is contained in:
David Rodríguez 2022-04-01 10:56:13 +02:00 committed by Hiroshi SHIBATA
parent 6dc314ac6d
commit f4009566af
Notes: git 2022-04-28 19:09:14 +09:00 
Merged: https://github.com/ruby/ruby/pull/5669
3 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/rubygems/source/git.rb
View File

@ -102,6 +102,7 @@ class Gem::Source::Git < Gem::Source
success = system @git, 'reset', '--quiet', '--hard', rev_parse success = system @git, 'reset', '--quiet', '--hard', rev_parse
if @need_submodules if @need_submodules
require "open3"
_, status = Open3.capture2e(@git, 'submodule', 'update', '--quiet', '--init', '--recursive') _, status = Open3.capture2e(@git, 'submodule', 'update', '--quiet', '--init', '--recursive')
success &&= status.success? success &&= status.success?

2
test/rubygems/test_gem_ext_cmake_builder.rb
View File

@ -9,6 +9,8 @@ class TestGemExtCmakeBuilder < Gem::TestCase
# Details: https://github.com/rubygems/rubygems/issues/1270#issuecomment-177368340 # Details: https://github.com/rubygems/rubygems/issues/1270#issuecomment-177368340
pend "CmakeBuilder doesn't work on Windows." if Gem.win_platform? pend "CmakeBuilder doesn't work on Windows." if Gem.win_platform?
require "open3"
begin begin
_, status = Open3.capture2e('cmake') _, status = Open3.capture2e('cmake')
pend 'cmake not present' unless status.success? pend 'cmake not present' unless status.success?

1
test/rubygems/test_gem_source_git.rb
View File

@ -68,6 +68,7 @@ class TestGemSourceGit < Gem::TestCase
git_gem 'b' git_gem 'b'
Dir.chdir 'git/a' do Dir.chdir 'git/a' do
require "open3"
output, status = Open3.capture2e(@git, 'submodule', '--quiet', 'add', File.expand_path('../b'), 'b') output, status = Open3.capture2e(@git, 'submodule', '--quiet', 'add', File.expand_path('../b'), 'b')
assert status.success?, output assert status.success?, output