[ruby/set] Speed up Set#flatten

Improved performance by ensuring that identical `Set` objects are
processed only once.

https://github.com/ruby/set/commit/cadb686e93
This commit is contained in:
Kouhei Yanagita 2024-11-29 12:31:54 +09:00 committed by Hiroshi SHIBATA
parent 96fac34797
commit f2334cf4b1

View File

@ -353,16 +353,19 @@ class Set
klass.new(self, *args, &block)
end
def flatten_merge(set, seen = Set.new) # :nodoc:
def flatten_merge(set, seen = {}) # :nodoc:
set.each { |e|
if e.is_a?(Set)
if seen.include?(e_id = e.object_id)
case seen[e_id = e.object_id]
when true
raise ArgumentError, "tried to flatten recursive Set"
when false
next
end
seen.add(e_id)
seen[e_id] = true
flatten_merge(e, seen)
seen.delete(e_id)
seen[e_id] = false
else
add(e)
end