1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use shape_id for determining "too complex"

Browse Source 
Using `rb_shape_obj_too_complex_p` looks up the shape, but we already
have the shape id. This avoids looking up the shape twice.
This commit is contained in:
Aaron Patterson 2025-05-19 09:58:14 -07:00 committed by Aaron Patterson
parent 6df6aaa036
commit ef935705cf
Notes: git 2025-05-21 17:27:26 +00:00 
Merged: https://github.com/ruby/ruby/pull/13373
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
variable.c
View File

@ -1423,7 +1423,7 @@ rb_ivar_lookup(VALUE obj, ID id, VALUE undef)
shape_id = RCLASS_SHAPE_ID(obj); shape_id = RCLASS_SHAPE_ID(obj);
#endif #endif
if (rb_shape_obj_too_complex_p(obj)) { if (rb_shape_id_too_complex_p(shape_id)) {
st_table * iv_table = RCLASS_FIELDS_HASH(obj); st_table * iv_table = RCLASS_FIELDS_HASH(obj);
if (rb_st_lookup(iv_table, (st_data_t)id, (st_data_t *)&val)) { if (rb_st_lookup(iv_table, (st_data_t)id, (st_data_t *)&val)) {
found = true; found = true;
@ -1464,7 +1464,7 @@ rb_ivar_lookup(VALUE obj, ID id, VALUE undef)
#if !SHAPE_IN_BASIC_FLAGS #if !SHAPE_IN_BASIC_FLAGS
shape_id = ROBJECT_SHAPE_ID(obj); shape_id = ROBJECT_SHAPE_ID(obj);
#endif #endif
if (rb_shape_obj_too_complex_p(obj)) { if (rb_shape_id_too_complex_p(shape_id)) {
st_table * iv_table = ROBJECT_FIELDS_HASH(obj); st_table * iv_table = ROBJECT_FIELDS_HASH(obj);
VALUE val; VALUE val;
if (rb_st_lookup(iv_table, (st_data_t)id, (st_data_t *)&val)) { if (rb_st_lookup(iv_table, (st_data_t)id, (st_data_t *)&val)) {