1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

* complex.c (nucomp_marshal_load): raise error on invalid data.

Browse Source 
reported by John Firebaugh [ruby-core:42860] [Bug #6076]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
naruse 2012-02-25 07:20:00 +00:00
parent 57657a0b9b
commit eeff98c430
4 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
Sat Feb 25 16:18:24 2012 NARUSE, Yui <naruse@ruby-lang.org>
* complex.c (nucomp_marshal_load): raise error on invalid data.
reported by John Firebaugh [ruby-core:42860] [Bug #6076]
Sat Feb 25 14:46:54 2012 Nobuyoshi Nakada <nobu@ruby-lang.org> Sat Feb 25 14:46:54 2012 Nobuyoshi Nakada <nobu@ruby-lang.org>
* ext/dl/dl.c (Init_dl): support intrinsic types, size_t, ptrdiff_t * ext/dl/dl.c (Init_dl): support intrinsic types, size_t, ptrdiff_t

2
complex.c
View File

@ -1260,6 +1260,8 @@ nucomp_marshal_load(VALUE self, VALUE a)
{ {
get_dat1(self); get_dat1(self);
Check_Type(a, T_ARRAY); Check_Type(a, T_ARRAY);
if (RARRAY_LEN(a) != 2)
rb_raise(rb_eArgError, "marshaled complex must have an array whose length is 2 but %ld", RARRAY_LEN(a));
dat->real = RARRAY_PTR(a)[0]; dat->real = RARRAY_PTR(a)[0];
dat->imag = RARRAY_PTR(a)[1]; dat->imag = RARRAY_PTR(a)[1];
rb_copy_generic_ivar(self, a); rb_copy_generic_ivar(self, a);

2
rational.c
View File

@ -1606,6 +1606,8 @@ nurat_marshal_load(VALUE self, VALUE a)
{ {
get_dat1(self); get_dat1(self);
Check_Type(a, T_ARRAY); Check_Type(a, T_ARRAY);
if (RARRAY_LEN(a) != 2)
rb_raise(rb_eArgError, "marshaled rational must have an array whose length is 2 but %ld", RARRAY_LEN(a));
dat->num = RARRAY_PTR(a)[0]; dat->num = RARRAY_PTR(a)[0];
dat->den = RARRAY_PTR(a)[1]; dat->den = RARRAY_PTR(a)[1];
rb_copy_generic_ivar(self, a); rb_copy_generic_ivar(self, a);

14
test/ruby/test_marshal.rb
View File

@ -469,4 +469,18 @@ class TestMarshal < Test::Unit::TestCase
assert_equal(o1.class, o2.class) assert_equal(o1.class, o2.class)
assert_equal(o1.foo, o2.foo) assert_equal(o1.foo, o2.foo)
end end
def test_marshal_complex
assert_raise(ArgumentError){Marshal.load("\x04\bU:\fComplex[\x05")}
assert_raise(ArgumentError){Marshal.load("\x04\bU:\fComplex[\x06i\x00")}
assert_equal(Complex(1, 2), Marshal.load("\x04\bU:\fComplex[\ai\x06i\a"))
assert_raise(ArgumentError){Marshal.load("\x04\bU:\fComplex[\bi\x00i\x00i\x00")}
end
def test_marshal_rational
assert_raise(ArgumentError){Marshal.load("\x04\bU:\rRational[\x05")}
assert_raise(ArgumentError){Marshal.load("\x04\bU:\rRational[\x06i\x00")}
assert_equal(Rational(1, 2), Marshal.load("\x04\bU:\rRational[\ai\x06i\a"))
assert_raise(ArgumentError){Marshal.load("\x04\bU:\rRational[\bi\x00i\x00i\x00")}
end
end end