1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rb_method_call_status: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-22 10:59:19 +09:00
parent f12efec2c2
commit edb1680a05
Notes: git 2020-06-29 11:06:36 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
vm_eval.c
View File

@ -632,8 +632,7 @@ rb_method_call_status(rb_execution_context_t *ec, const rb_callable_method_entry
rb_method_visibility_t visi; rb_method_visibility_t visi;
if (UNDEFINED_METHOD_ENTRY_P(me)) { if (UNDEFINED_METHOD_ENTRY_P(me)) {
undefined: goto undefined;
return scope == CALL_VCALL ? MISSING_VCALL : MISSING_NOENTRY;
} }
if (me->def->type == VM_METHOD_TYPE_REFINED) { if (me->def->type == VM_METHOD_TYPE_REFINED) {
me = rb_resolve_refined_method_callable(Qnil, me); me = rb_resolve_refined_method_callable(Qnil, me);
@ -667,6 +666,8 @@ rb_method_call_status(rb_execution_context_t *ec, const rb_callable_method_entry
} }
return MISSING_NONE; return MISSING_NONE;
undefined:
return scope == CALL_VCALL ? MISSING_VCALL : MISSING_NOENTRY;
} }