1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] Bad auth should not fallback either

Browse Source 
https://github.com/rubygems/rubygems/commit/ba3ea27869
This commit is contained in:
David Rodríguez 2023-08-10 17:23:32 +02:00 committed by Hiroshi SHIBATA
parent c076ac8a5f
commit e678affe70
No known key found for this signature in database
GPG Key ID: F9CF13417264FAC2
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/bundler/fetcher/compact_index.rb
View File

@ -15,7 +15,7 @@ module Bundler
method.bind(self).call(*args, &blk) method.bind(self).call(*args, &blk)
rescue NetworkDownError, CompactIndexClient::Updater::MisMatchedChecksumError => e rescue NetworkDownError, CompactIndexClient::Updater::MisMatchedChecksumError => e
raise HTTPError, e.message raise HTTPError, e.message
rescue AuthenticationRequiredError rescue AuthenticationRequiredError, BadAuthenticationError
# Fail since we got a 401 from the server. # Fail since we got a 401 from the server.
raise raise
rescue HTTPError => e rescue HTTPError => e

9
spec/bundler/install/gems/compact_index_spec.rb
View File

@ -683,6 +683,15 @@ The checksum of /versions does not match the checksum provided by the server! So
bundle :install, :artifice => "compact_index_strict_basic_authentication", :raise_on_error => false bundle :install, :artifice => "compact_index_strict_basic_authentication", :raise_on_error => false
expect(err).to include("Bad username or password") expect(err).to include("Bad username or password")
end end
it "does not fallback to old dependency API if bad authentication is provided" do
bundle "config set #{source_hostname} #{user}:wrong"
bundle :install, :artifice => "compact_index_strict_basic_authentication", :raise_on_error => false, :verbose => true
expect(err).to include("Bad username or password")
expect(out).to include("HTTP 401 Unauthorized http://user@localgemserver.test/versions")
expect(out).not_to include("HTTP 401 Unauthorized http://user@localgemserver.test/api/v1/dependencies")
end
end end
describe "with no password" do describe "with no password" do