1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

* test/openssl/test_cipher.rb (test_aes_gcm_wrong_tag): Don't use

Browse Source 
String#succ because it can make modified (wrong) auth_tag longer
  than 16 bytes.  The longer auth_tag makes that
  EVP_CIPHER_CTX_ctrl (and internally aes_gcm_ctrl) fail.
  [ruby-core:55143] [Bug #8439] reported by Vit Ondruch.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43676 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
akr 2013-11-14 10:58:15 +00:00
parent 04c7fa0f3b
commit e4f8f8907c
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
Thu Nov 14 19:53:00 2013 Tanaka Akira <akr@fsij.org>
* test/openssl/test_cipher.rb (test_aes_gcm_wrong_tag): Don't use
String#succ because it can make modified (wrong) auth_tag longer
than 16 bytes. The longer auth_tag makes that
EVP_CIPHER_CTX_ctrl (and internally aes_gcm_ctrl) fail.
[ruby-core:55143] [Bug #8439] reported by Vit Ondruch.
Thu Nov 14 11:35:37 2013 Nobuyoshi Nakada <nobu@ruby-lang.org> Thu Nov 14 11:35:37 2013 Nobuyoshi Nakada <nobu@ruby-lang.org>
* hash.c (hash_foreach_ensure): restore iter_lev to the previous * hash.c (hash_foreach_ensure): restore iter_lev to the previous

3
test/openssl/test_cipher.rb
View File

@ -187,7 +187,8 @@ class OpenSSL::TestCipher < Test::Unit::TestCase
tag = cipher.auth_tag tag = cipher.auth_tag
decipher = new_decryptor('aes-128-gcm', key, iv) decipher = new_decryptor('aes-128-gcm', key, iv)
decipher.auth_tag = tag[0..-2] << tag[-1].succ tag.setbyte(-1, (tag.getbyte(-1) + 1) & 0xff)
decipher.auth_tag = tag
decipher.auth_data = "aad" decipher.auth_data = "aad"
assert_raise OpenSSL::Cipher::CipherError do assert_raise OpenSSL::Cipher::CipherError do