1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't incremental mark when GC stressful

Browse Source 
Incremental marking prevents the GC from fully executing, so it may fail
to catch certain bugs.
This commit is contained in:
Peter Zhu 2023-11-27 11:13:47 -05:00
parent 7973eb7c3f
commit e3875dd0f8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gc.c
View File

@ -9404,7 +9404,6 @@ static int
gc_start(rb_objspace_t *objspace, unsigned int reason) gc_start(rb_objspace_t *objspace, unsigned int reason)
{ {
unsigned int do_full_mark = !!(reason & GPR_FLAG_FULL_MARK); unsigned int do_full_mark = !!(reason & GPR_FLAG_FULL_MARK);
unsigned int immediate_mark = reason & GPR_FLAG_IMMEDIATE_MARK;
/* reason may be clobbered, later, so keep set immediate_sweep here */ /* reason may be clobbered, later, so keep set immediate_sweep here */
objspace->flags.immediate_sweep = !!(reason & GPR_FLAG_IMMEDIATE_SWEEP); objspace->flags.immediate_sweep = !!(reason & GPR_FLAG_IMMEDIATE_SWEEP);
@ -9449,7 +9448,9 @@ gc_start(rb_objspace_t *objspace, unsigned int reason)
reason |= GPR_FLAG_MAJOR_BY_FORCE; /* GC by CAPI, METHOD, and so on. */ reason |= GPR_FLAG_MAJOR_BY_FORCE; /* GC by CAPI, METHOD, and so on. */
} }
if (objspace->flags.dont_incremental || immediate_mark) { if (objspace->flags.dont_incremental ||
reason & GPR_FLAG_IMMEDIATE_MARK ||
ruby_gc_stressful) {
objspace->flags.during_incremental_marking = FALSE; objspace->flags.during_incremental_marking = FALSE;
} }
else { else {