From e1bae2c6930cee58586e9c9d7999b0143af3ee23 Mon Sep 17 00:00:00 2001 From: eileencodes Date: Wed, 17 Jan 2024 10:24:34 -0500 Subject: [PATCH] [Prism] Implement defined? for PM_INDEX_OR_WRITE_NODE Ruby code: ```ruby defined?([0][0] ||= 1) ``` Instructions: ``` "********* Ruby *************" == disasm: #@:1 (1,0)-(59,58)> 0000 putobject "assignment" ( 59)[Li] 0002 leave "********* PRISM *************" == disasm: #@:58 (58,0)-(58,58)> 0000 putobject "assignment" ( 58)[Li] 0002 leave ``` Related: ruby/prism#2188 --- prism_compile.c | 1 + test/ruby/test_compile_prism.rb | 1 + 2 files changed, 2 insertions(+) diff --git a/prism_compile.c b/prism_compile.c index dc2b3387fe..95bdbece42 100644 --- a/prism_compile.c +++ b/prism_compile.c @@ -2712,6 +2712,7 @@ pm_compile_defined_expr0(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *co case PM_INDEX_AND_WRITE_NODE: case PM_INDEX_OPERATOR_WRITE_NODE: + case PM_INDEX_OR_WRITE_NODE: case PM_INSTANCE_VARIABLE_WRITE_NODE: case PM_INSTANCE_VARIABLE_OPERATOR_WRITE_NODE: diff --git a/test/ruby/test_compile_prism.rb b/test/ruby/test_compile_prism.rb index def4bd1e26..f46c491598 100644 --- a/test/ruby/test_compile_prism.rb +++ b/test/ruby/test_compile_prism.rb @@ -247,6 +247,7 @@ module Prism assert_prism_eval("defined?(Prism::CPWN = 1)") assert_prism_eval("defined?([0][0] &&= 1)") assert_prism_eval("defined?([0][0] += 1)") + assert_prism_eval("defined?([0][0] ||= 1)") end def test_GlobalVariableReadNode