1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/json] Avoid plain char for ctype macros

Browse Source 
On some platforms ctype functions are defined as macros accesing tables.
A plain char may be `signed` or `unsigned` per implementations and the
extension result implementation dependent.

gcc warns such case:

```
parser.c: In function 'rstring_cache_fetch':
parser.c:138:33: warning: array subscript has type 'char' [-Wchar-subscripts]
  138 |     if (RB_UNLIKELY(!isalpha(str[0]))) {
      |                              ~~~^~~
parser.c: In function 'rsymbol_cache_fetch':
parser.c:190:33: warning: array subscript has type 'char' [-Wchar-subscripts]
  190 |     if (RB_UNLIKELY(!isalpha(str[0]))) {
      |                              ~~~^~~
```

https://github.com/ruby/json/commit/4431b362f6
This commit is contained in:
Nobuyoshi Nakada 2025-01-30 12:27:45 +09:00
parent 7f70ef64af
commit dc3d2a3c2f
No known key found for this signature in database
GPG Key ID: 3582D74E1FEE4465
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ext/json/parser/parser.c
View File

@ -135,7 +135,7 @@ static VALUE rstring_cache_fetch(rvalue_cache *cache, const char *str, const lon
return Qfalse; return Qfalse;
} }
if (RB_UNLIKELY(!isalpha(str[0]))) { if (RB_UNLIKELY(!isalpha((unsigned char)str[0]))) {
// Simple heuristic, if the first character isn't a letter, // Simple heuristic, if the first character isn't a letter,
// we're much less likely to see this string again. // we're much less likely to see this string again.
// We mostly want to cache strings that are likely to be repeated. // We mostly want to cache strings that are likely to be repeated.
@ -187,7 +187,7 @@ static VALUE rsymbol_cache_fetch(rvalue_cache *cache, const char *str, const lon
return Qfalse; return Qfalse;
} }
if (RB_UNLIKELY(!isalpha(str[0]))) { if (RB_UNLIKELY(!isalpha((unsigned char)str[0]))) {
// Simple heuristic, if the first character isn't a letter, // Simple heuristic, if the first character isn't a letter,
// we're much less likely to see this string again. // we're much less likely to see this string again.
// We mostly want to cache strings that are likely to be repeated. // We mostly want to cache strings that are likely to be repeated.