From db7f3496dd4485149c68912677f231dc434824b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?= Date: Mon, 6 Jul 2020 11:51:53 +0900 Subject: [PATCH] nobody uses the return value of vm_push_frame Surprised to see such a waste of time in this super duper hot path. --- vm_insnhelper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/vm_insnhelper.c b/vm_insnhelper.c index f2cab2f4b5..c98dfa87e7 100644 --- a/vm_insnhelper.c +++ b/vm_insnhelper.c @@ -287,7 +287,7 @@ vm_check_canary(const rb_execution_context_t *ec, VALUE *sp) #define vm_check_frame(a, b, c, d) #endif /* VM_CHECK_MODE > 0 */ -static inline rb_control_frame_t * +static void vm_push_frame(rb_execution_context_t *ec, const rb_iseq_t *iseq, VALUE type, @@ -370,8 +370,6 @@ vm_push_frame(rb_execution_context_t *ec, } } #endif - - return cfp; } /* return TRUE if the frame is finished */