1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Prefer calloc/free over ZALLOC/xfree

Browse Source 
To avoid SEGV like
http://ci.rvm.jp/logfiles/brlog.trunk-mjit.20201124-061530
This commit is contained in:
Takashi Kokubun 2020-11-23 23:47:58 -08:00
parent 0deb06bfa4
commit cfd8c7e6ca
No known key found for this signature in database
GPG Key ID: 6FFC433B12EE23DD
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mjit.c
View File

@ -183,7 +183,10 @@ mjit_cont_new(rb_execution_context_t *ec)
{ {
struct mjit_cont *cont; struct mjit_cont *cont;
cont = ZALLOC(struct mjit_cont); // We need to use calloc instead of something like ZALLOC to avoid triggering GC here.
// When this function is called from rb_thread_alloc through rb_threadptr_root_fiber_setup,
// the thread is still being prepared and marking it causes SEGV.
cont = calloc(1, sizeof(struct mjit_cont));
cont->ec = ec; cont->ec = ec;
CRITICAL_SECTION_START(3, "in mjit_cont_new"); CRITICAL_SECTION_START(3, "in mjit_cont_new");
@ -218,7 +221,7 @@ mjit_cont_free(struct mjit_cont *cont)
} }
CRITICAL_SECTION_FINISH(3, "in mjit_cont_new"); CRITICAL_SECTION_FINISH(3, "in mjit_cont_new");
xfree(cont); free(cont);
} }
// Finish work with continuation info. // Finish work with continuation info.