1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] github source should default to secure protocol

Browse Source 
Bundler 2 switched to secure https here c2e81f8ff6

Insecure protocols should be avoided to prevent MITM attacks.

https://github.com/rubygems/rubygems/commit/758413364a
This commit is contained in:
Jason Karns 2022-10-28 15:30:21 -04:00 committed by Hiroshi SHIBATA
parent adfbee85e0
commit ceeefb5870
Notes: git 2025-04-09 13:49:37 +00:00 
Merged: https://github.com/ruby/ruby/pull/6715
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/rubygems/request_set/gem_dependency_api.rb
View File

@ -214,7 +214,7 @@ class Gem::RequestSet::GemDependencyAPI
git_source :github do |repo_name| git_source :github do |repo_name|
repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include? "/" repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include? "/"
"git://github.com/#{repo_name}.git" "https://github.com/#{repo_name}.git"
end end
git_source :bitbucket do |repo_name| git_source :bitbucket do |repo_name|

4
test/rubygems/test_gem_request_set_gem_dependency_api.rb
View File

@ -183,7 +183,7 @@ class TestGemRequestSetGemDependencyAPI < Gem::TestCase
assert_equal [dep("a")], @set.dependencies assert_equal [dep("a")], @set.dependencies
assert_equal %w[git://github.com/example/repository.git master], assert_equal %w[https://github.com/example/repository.git master],
@git_set.repositories["a"] @git_set.repositories["a"]
expected = { "a" => Gem::Requirement.create("!") } expected = { "a" => Gem::Requirement.create("!") }
@ -196,7 +196,7 @@ class TestGemRequestSetGemDependencyAPI < Gem::TestCase
assert_equal [dep("a")], @set.dependencies assert_equal [dep("a")], @set.dependencies
assert_equal %w[git://github.com/example/example.git master], assert_equal %w[https://github.com/example/example.git master],
@git_set.repositories["a"] @git_set.repositories["a"]
expected = { "a" => Gem::Requirement.create("!") } expected = { "a" => Gem::Requirement.create("!") }