1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/prism] Emit error for constant assignments in defs

Browse Source 
https://github.com/ruby/prism/commit/864b06f90e
This commit is contained in:
Haldun Bayhantopcu 2023-12-06 23:05:55 +01:00 committed by git
parent 9d9865d9bc
commit ce094e8556
4 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
prism/diagnostic.c
View File

@ -255,6 +255,7 @@ static const char* const diagnostic_messages[PM_DIAGNOSTIC_ID_LEN] = {
[PM_ERR_UNTIL_TERM] = "expected an `end` to close the `until` statement",
[PM_ERR_VOID_EXPRESSION] = "unexpected void value expression",
[PM_ERR_WHILE_TERM] = "expected an `end` to close the `while` statement",
[PM_ERR_WRITE_TARGET_IN_METHOD] = "dynamic constant assignment",
[PM_ERR_WRITE_TARGET_READONLY] = "immutable variable as a write target",
[PM_ERR_WRITE_TARGET_UNEXPECTED] = "unexpected write target",
[PM_ERR_XSTRING_TERM] = "expected a closing delimiter for the `%x` or backtick string",

1
prism/diagnostic.h
View File

@ -247,6 +247,7 @@ typedef enum {
PM_ERR_UNTIL_TERM,
PM_ERR_VOID_EXPRESSION,
PM_ERR_WHILE_TERM,
PM_ERR_WRITE_TARGET_IN_METHOD,
PM_ERR_WRITE_TARGET_READONLY,
PM_ERR_WRITE_TARGET_UNEXPECTED,
PM_ERR_XSTRING_TERM,

3
prism/prism.c
View File

@ -10685,6 +10685,9 @@ parse_write(pm_parser_t *parser, pm_node_t *target, pm_token_t *operator, pm_nod
return (pm_node_t *) pm_constant_path_write_node_create(parser, (pm_constant_path_node_t *) target, operator, value);
case PM_CONSTANT_READ_NODE: {
pm_constant_write_node_t *node = pm_constant_write_node_create(parser, (pm_constant_read_node_t *) target, operator, value);
if (context_def_p(parser)) {
pm_parser_err_node(parser, (pm_node_t *) node, PM_ERR_WRITE_TARGET_IN_METHOD);
}
pm_node_destroy(parser, target);
return (pm_node_t *) node;
}

7
test/prism/errors_test.rb
View File

@ -1971,6 +1971,13 @@ module Prism
end
end
def test_constant_assignment_in_method
source = 'def foo();A=1;end'
assert_errors expression(source), source, [
['dynamic constant assignment', 10..13]
]
end
private
def assert_errors(expected, source, errors, compare_ripper: RUBY_ENGINE == "ruby")