1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ruby/open-uri] feat: allow option to pass version of SSL / TLS to use during communication. Allow versions are OpenSSL::SSL::SSLContext::METHODS

Browse Source 
https://github.com/ruby/open-uri/commit/8729858517
This commit is contained in:
Nishant Patel 2022-02-05 14:29:38 +11:00 committed by git
parent 7f80ec47c3
commit cdbaac3f4b
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/open-uri.rb
View File

@ -99,6 +99,7 @@ module OpenURI
:open_timeout => true, :open_timeout => true,
:ssl_ca_cert => nil, :ssl_ca_cert => nil,
:ssl_verify_mode => nil, :ssl_verify_mode => nil,
:ssl_version => nil,
:ftp_active_mode => false, :ftp_active_mode => false,
:redirect => true, :redirect => true,
:encoding => nil, :encoding => nil,
@ -298,6 +299,8 @@ module OpenURI
require 'net/https' require 'net/https'
http.use_ssl = true http.use_ssl = true
http.verify_mode = options[:ssl_verify_mode] || OpenSSL::SSL::VERIFY_PEER http.verify_mode = options[:ssl_verify_mode] || OpenSSL::SSL::VERIFY_PEER
http.ssl_version = options[:ssl_version] if options[:ssl_version] &&
OpenSSL::SSL::SSLContext::METHODS.include?(options[:ssl_version])
store = OpenSSL::X509::Store.new store = OpenSSL::X509::Store.new
if options[:ssl_ca_cert] if options[:ssl_ca_cert]
Array(options[:ssl_ca_cert]).each do |cert| Array(options[:ssl_ca_cert]).each do |cert|

10
test/open-uri/test_ssl.rb
View File

@ -107,6 +107,16 @@ class TestOpenURISSL
} }
end end
def test_validation_ssl_version
with_https {|srv, dr, url|
setup_validation(srv, dr)
URI.open("#{url}/data", :ssl_verify_mode => OpenSSL::SSL::VERIFY_NONE, :ssl_version => :TLSv1_2) {|f|
assert_equal("200", f.status[0])
assert_equal("ddd", f.read)
}
}
end
def with_https_proxy(proxy_log_tester=lambda {|proxy_log, proxy_access_log| assert_equal([], proxy_log) }) def with_https_proxy(proxy_log_tester=lambda {|proxy_log, proxy_access_log| assert_equal([], proxy_log) })
proxy_log = [] proxy_log = []
proxy_logger = WEBrick::Log.new(proxy_log, WEBrick::BasicLog::WARN) proxy_logger = WEBrick::Log.new(proxy_log, WEBrick::BasicLog::WARN)